Change adaptive sample groups to use Globs #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-overengineer
suggested changes
Jul 12, 2021
| @@ -275,7 +274,7 @@ object AdaptiveSampler { | |||
|
|
|||
| Settings.Group( | |||
| name = groupName, | |||
| operations = groupConfig.getStringList("operations").asScala.toSeq, | |||
| operations = groupConfig.getStringList("operations").asScala.toSeq.map(Filter.fromGlob), | |||
There was a problem hiding this comment.
Don't like this, for two reasons:
- We should allow people to use regular expressions, if they want to
- This is not backwards compatible! We know some people have already set it up to raw strings.
What I suggest we do is:
- Copy logic from
- Change it so that the default is not glob, but it's exact match (a new type of filter, I guess,
Filter.StringMatchor something) - Immediately announce exact match as deprecated
- Move to default-to-glob in the next minor version (2.3.0, I guess)
Thoughts, @SimunKaracic , @ivantopo?
There was a problem hiding this comment.
Assuming you mean this under 1.
That all sounds like a great idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.