Reproducer: Span operation name duplicated when more than 1 endpoint defined per route #1063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
sbt-guardrail
to generate akka-httpRoutes
from an OpenAPI spec. I'm instrumenting these endpoints with Kamon's akka-http integration. I noticed that the waysbt-guardrail
generates the akka-httpRoute
sometimes causes an issue with how operation names are generated for spans. Guardrail will defineRoutes
by theirpath
and then define the HTTP verb as a nestedDirective
. This appears to cause confusion with how paths are matched in the akka-http/Kamon akka-http server instrumentation code.i.e.)
Reproducer test fails with: