Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow W3C TraceContext propagation in kamon-kafka #1237

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

Symbianx
Copy link
Contributor

@Symbianx Symbianx commented Dec 22, 2022

Fixes #1235 by adding a new configuration key kamon.instrumentation.kafka.client.tracing.propagator that can take the value w3c to propagate the trace context using the W3C TraceContext specification.

Please excuse any bad scala code, I'm still a newb in this ecosystem.

@Symbianx
Copy link
Contributor Author

Symbianx commented Dec 22, 2022

Haven't done tests yet because I'm having issues compiling kamon-core which fails with unresolved dependencies for javax.annotation.Generated and sun.misc.Contended.

I have I feeling I'm using the wrong sbt or java versions but can't find any information on what settings I should be using to compile the project.

Turns out I need to build using java 8, or at least that did it for me. Will work on adding tests.

@Symbianx
Copy link
Contributor Author

Symbianx commented Dec 23, 2022

Added a tests to assert w3c is being used when configured and rebased the PR into 1 commit.

@ivantopo ivantopo self-assigned this Jan 11, 2023
Copy link
Contributor

@ivantopo ivantopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Symbianx, thanks so much for the PR! There is a tiny change required for this to compile on early Scala versions and other than that, it looks good to me.

It would be nice to propagate context tags as W3C baggage so that they don't get lost at this point, but I think that's something that should be addressed on a separate PR.

@ivantopo ivantopo merged commit 068b4da into kamon-io:master Jan 16, 2023
@ivantopo
Copy link
Contributor

Thanks @Symbianx!

Turns out I already opened an issue regarding w3c-baggage: #803. Let's follow up on that over there.

@Symbianx
Copy link
Contributor Author

Thank you for merging @ivantopo! 🎉
When can we expect this change to be released? Is there a release cadence we should be aware of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka instrumentation is not using w3c for context propagation
2 participants