Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1248 add a support for New Relic's licence key #1249

Merged
merged 4 commits into from
Jan 23, 2023
Merged

#1248 add a support for New Relic's licence key #1249

merged 4 commits into from
Jan 23, 2023

Conversation

bwiercinski
Copy link
Contributor

solves #1248

  • changes are compatible backwards
  • extracted config parsing to the new file
  • new "licence-key" can be passed
  • added new tests
  • upgraded new relic's telemetry lib version (this will solve vulnerabilities this and that)

to maintainers, please:

  • review if formatting is ok, i've used intellij formatter
  • review if i didn't miss a spot where insights key is used (ctrl+shift+f didn't find any)
  • tell me how to publish snapshot of it. i want to test it e2e on my app

@bwiercinski
Copy link
Contributor Author

oh and i guess that https://kamon.io/docs/latest/reporters/newrelic/ must be updated

@bwiercinski
Copy link
Contributor Author

yes? no? maybe? @dpsoft @ivantopo sorry that I'm tagging you directly

@bwiercinski
add a support for New Relic's licence key
29cd792 
- changes are compatible backwards
- extracted config parsing to the new file
- new `"licence-key"` can be passed
- added new tests
@bwiercinski bwiercinski force-pushed the 1248-add_new_relic_licence_key_support branch from dbce2d1 to 7914186 Compare January 16, 2023 10:41
@bwiercinski bwiercinski force-pushed the 1248-add_new_relic_licence_key_support branch from 7914186 to 5ad74eb Compare January 16, 2023 12:32
@bwiercinski
Copy link
Contributor Author

bwiercinski commented Jan 16, 2023 •
edited
Loading

i have no idea why previous pipeline failed. the tests in +reporters are passing

@ivantopo
Copy link
Contributor

@bwiercinski it is a compilation issue for Scala 2.11. Take a look here: https://github.com/kamon-io/Kamon/actions/runs/3930402881/jobs/6727190664#step:6:15451. Not sure what exactly is the problem, though 🤔

@bwiercinski
Copy link
Contributor Author

can you reproduce it locally?

@bwiercinski
Copy link
Contributor Author

it is passing now, maybe there was some old compilation cache causing the errors. is it all good then? i would love to see it released

@bwiercinski @matwojcik
Update reporters/kamon-newrelic/src/main/scala/kamon/newrelic/spans/S…
a240a57 
…panBatchSenderBuilder.scala

Co-authored-by: Mateusz Wójcik <mat.wojcik@gmail.com>
@bwiercinski
Copy link
Contributor Author

@ivantopo is all good :)?

@ivantopo ivantopo merged commit 5bade8d into kamon-io:master Jan 23, 2023
@ivantopo
Copy link
Contributor

All good @bwiercinski, thanks for the contribution!

@bwiercinski bwiercinski deleted the 1248-add_new_relic_licence_key_support branch January 24, 2023 07:29
@bwiercinski
Copy link
Contributor Author

thanks, looking forward for the release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matwojcik matwojcik matwojcik left review comments

@majk-p majk-p majk-p left review comments

@ivantopo ivantopo ivantopo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bwiercinski @ivantopo @matwojcik @majk-p