New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Khronus metrics reporter #365

Merged
merged 1 commit into from Jul 23, 2016

Conversation

Projects
None yet
2 participants
@crypticmind
Contributor

crypticmind commented Jun 28, 2016

This adds a new reporter to send histogram, counter, gauge, trace metrics to Khronus.

Currently, this uses com.despegar:khronus-java-client which has a dependency on Apache's HttpClient. Perhaps in a future release the underlying Khronus client can be swapped.

The reference.conf file has sensible defaults pointing to a Khronus instance running on localhost. To make this baby work in a service, this is the minimum configuration required:

kamon {
  khronus {
    host = "1.2.3.4:5678"
    app-name = "your-service-name-here"
  }
  modules {
    kamon-khronus.auto-start = yes
  }
}
@crypticmind

This comment has been minimized.

Contributor

crypticmind commented Jun 28, 2016

@ivantopo please come 'ere and tell me your thoughts

@crypticmind

This comment has been minimized.

Contributor

crypticmind commented Jun 29, 2016

I've just updated the implementation to also subscribe to executor-service metrics

@dpsoft

This comment has been minimized.

Contributor

dpsoft commented Jul 8, 2016

@crypticmind the PR looks good for me, meanwhile just need to ask you please change the message to something like + add Khronus metrics reporter and will merge right away, just to match our commit message conventions. I would like to merge it BUT there is one missing piece, not in this repository but in our documentation website! yes, I know, it is a bit boring to write docs but it is a necessary thing... so if you could create a simple one page doc explaining what this module does, how it reports data and possibly some screenshots of what kind of visualization or results you can get out of it would be super helpful even for us, to start experimenting with this :D.. take a look at the Datadog, StatsD and New Relic pages on our website to get an idea of what we would like to see there.

BTW: @ivantopo WDYT

@crypticmind

This comment has been minimized.

Contributor

crypticmind commented Jul 12, 2016

I've updated this PR and also created another one for the site.

@dpsoft dpsoft merged commit 2cfe78a into kamon-io:master Jul 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dpsoft

This comment has been minimized.

Contributor

dpsoft commented Jul 23, 2016

@crypticmind thank for this PR!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment