Add KamonRemoteInstrument #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of this commit, context propagation looks ok, but there are deserialization errors happening on HandshakeReq
SimunKaracic
force-pushed
the
akka-cluster-partial-kamon
branch
from
1a50fc0
to
9119855
Compare
SimunKaracic
force-pushed
the
akka-cluster-partial-kamon
branch
2 times, most recently
from
401585c
to
4a5d681
Compare
|
nice! will this fix #767 ? |
instrumentation/kamon-akka/build.sbt
Outdated
| val `Akka-2.5-version` = "2.5.26" | ||
| val `Akka-2.6-version` = "2.6.0" | ||
| // latest is 2.6.10 |
There was a problem hiding this comment.
They released a new one! How dare they!
SimunKaracic
force-pushed
the
akka-cluster-partial-kamon
branch
from
d58d55b
to
ec0a141
Compare
Now it works with akka 2.5.x and 2.6.7
SimunKaracic
force-pushed
the
akka-cluster-partial-kamon
branch
from
ec0a141
to
ee12a4b
Compare
ivantopo
requested changes
Jan 19, 2021
It is now in the akka module, since it must always be enabled when that module is enabled.
ivantopo
approved these changes
Jan 19, 2021
This was referenced Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
Added KamonRemoteInstrument, refactored part of BinaryPropagation (new code is in
storeContextInBuffer, which I'll refactor, but wanted to get something up and running ASAP).problems
As of this commit, context propagation looks ok, but there's a warning when deserializing a HandshakeReq.
I can't find what's causing the warning.
I have also tried removing the existing Remoting instrumentation, but nothing changed.
Pertinent logs (with DEBUG):
[2020-12-15 15:54:06,407] [DEBUG] [akka.remote.artery.RemoteInstruments] [] [ClusterSystem-akka.actor.default-dispatcher-5] - Skipping local RemoteInstrument 8 that has no matching data in the messageis expected, since ourRemoteInstrumentwon't put anything in the metadata when the context is empty.This is the same warning that was being triggered when Kamon wasn't on all nodes in a cluster, and is now present when Kamon is running on both nodes :/
The warning only appears on the side that's receiving the message, and it shows up 4 times when a node tries to join the cluster. The nodes continue communicating without a problem (that I can see :/) after that.
The warning is not present in
2.1.9when all nodes have Kamon. So it's something triggered by my changes, or their interaction with existing instrumentation :)Not sure how to tackle this. Any ideas?