bring tracing support for Cassandra 4.x driver, fixes #798 #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantopo
changed the title
SimunKaracic
reviewed
Mar 8, 2021
| test in Test := { | ||
| (test in Cassandra3xTest).value | ||
| (test in Cassandra4xTest).value | ||
| } |
There was a problem hiding this comment.
Make your editor add newline on save!
ivantopo
force-pushed
the
issue-#798/instrument-4x-cassandra-driver
branch
from
5e19206
to
48d84b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings query tracing for the Cassandra Driver 4.x. A few notes on differences to the 3.x support:
From the experience we had with the 3.x driver I would say that we should forget about trying to add connection pool metrics, but we should add basic monitoring of the Throttler implementations and optional executions tracing. Those two don't seem too hard to achieve, but I will not include them on this PR.