Skip to content
This repository has been archived by the owner on Mar 29, 2020. It is now read-only.

StatsD reporter for Kamon 2.0 #8

Merged
merged 2 commits into from
Dec 2, 2019
Merged

StatsD reporter for Kamon 2.0 #8

merged 2 commits into from
Dec 2, 2019

Conversation

xeppaka
Copy link

@xeppaka xeppaka commented Sep 5, 2019

No description provided.

@xeppaka xeppaka force-pushed the master branch 3 times, most recently from a86b436 to d9a2bda Compare September 6, 2019 18:21
@kvma kvma mentioned this pull request Sep 6, 2019
Closed
ivantopo
ivantopo reviewed Oct 7, 2019
View reviewed changes
Copy link
Contributor

@ivantopo ivantopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xeppaka, thanks a lot for bringing this up! There are just a few comments regarding consistency with other modules and timers are not being reported, but that's minor stuff. Lot's of people will be happy about this! 🎉

One thing I didn't manage to do was actually firing up a StatsD and giving this a try.. have you tried it on a real app?

project/Dependencies.scala Outdated Show resolved Hide resolved
project/plugins.sbt Outdated Show resolved Hide resolved
src/main/resources/reference.conf Outdated Show resolved Hide resolved
src/main/scala/kamon/statsd/StatsDReporter.scala Outdated Show resolved Hide resolved
src/main/scala/kamon/statsd/StatsDReporter.scala Outdated Show resolved Hide resolved
@TimSoethout TimSoethout mentioned this pull request Oct 14, 2019
Closed
@xeppaka
Copy link
Author

xeppaka commented Oct 16, 2019

Fixed all code review comments

@khrupalyk
Copy link

Hi @ivantopo , @xeppaka . When do you plan to merge this PR?

@patrickcunningham
Copy link

Hello, we would love to see this PR merged so that we can use it. Do you have a timeline for when that might happen?

Great work @xeppaka :)

@jontra
Copy link

jontra commented Nov 7, 2019

Any plans to merge this PR any time soon?

@ivantopo ivantopo merged commit 5d58a31 into kamon-io:master Dec 2, 2019
@ivantopo
Copy link
Contributor

ivantopo commented Dec 2, 2019

Hey @xeppaka and folks around, thanks a lot for this PR and for the insane patience! I just merged with a couple minor changes and released this as 2.0.0. Please give it a try and report back if you find any issues.

The release is already on our Bintray repo and on its way to Maven Central.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ivantopo ivantopo ivantopo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xeppaka @khrupalyk @patrickcunningham @jontra @ivantopo