Optimize within pattern matching for Kanela modules [WIP]
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the end of the day, we'll probably manually add modules we're interested in, instead of using the bundle. |
melezov
commented
Jun 11, 2022
| "app.kanela..*", | ||
| "java.net.*" | ||
| "app\\.kanela\\..*", | ||
| "java\\.net\\..*", |
There was a problem hiding this comment.
Technically, these could be .+, but it shouldn't really matter
melezov
changed the title
within pattern matching for Kanela modules
melezov
changed the title
within pattern matching for Kanela moduleswithin pattern matching for Kanela modules [WIP]
added 5 commits
June 13, 2022 14:15
ByteBuddy's StringMatcher uses String.matches which performs about 10x slower than caching a Pattern inside a custom PatternMatcher Uglify the test / reference pattern examples to more closely match the required patterns Flag incorrect InstrumentationLoader test
FlatSpec was removed in 3.2.x and replaced with AnyFlatSpec Explicitly import Matchers and drop unused BeforeAndAfterAll usage
Bump scala library: 2.12.16 Bump config dependency: 1.4.2 Bump vavr dependency: 0.10.4 Bump lombok: 1.18.24 Bump plugins: scalatest 0.32 and shadow 7.1.2 Bump logback in tests: 1.2.11 Remove sunsetted jcenter repository Prefix deprecated keys: (baseName|version|classifier) with `archive` Drop unused project/build.properties SBT leftover
Use Class.getConstructors()[0].newInstance() for InstrumentationLoader Misc tweaks - use https in a few places
|
Send a shout if you need this broken into multiple PRs. Tests should be good now. |
|
@melezov thanks for this PR, I'll take a look ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteBuddy's StringMatcher uses String.matches which performs about 10x slower than caching a Pattern inside a custom PatternMatcher
Uglify the test / reference pattern examples to more closely match the required patterns
This change speeds up the boot of our production by 5-10% (times in ms)
Context: Testing the Kamon Bundle in our SaaS and probing how to reduce the now prolonged boot times.
The matches method of StringMatcher gets invoked about a million times during the boot (can provide logs) and seems to be a hotspot worth looking into.