Allow step element to be a HTMLElement #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamranahmedse
requested changes
Mar 22, 2018
src/index.js
Outdated
| @@ -239,7 +239,7 @@ export default class Driver { | |||
| this.steps = []; | |||
|
|
|||
| steps.forEach((step, index) => { | |||
| if (!step.element || typeof step.element !== 'string') { | |||
| if ((!step.element || !(typeof step.element === 'string' || step.element instanceof HTMLElement))) { | |||
There was a problem hiding this comment.
HTMLElement won't be available in browsers not supporting W3 DOM2 (or IE in other words). Would be better to use nodeType
There was a problem hiding this comment.
No worries. I'd tested in IE11+ but don't have access to older IEs at the moment as have no need to support them in projects I'm working on. I've updated the PR with a step.element.nodeType > 0 check - but again haven't been able to test in older IEs.
martinruvalcaba
approved these changes
Mar 26, 2018
|
Any plans on merging this? This would also help to make this library work with shadow dom. |
|
Added in 523519f Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would find it useful to be able to pass in an existing DOM node rather than a queryString, so I think this PR should allow for that. The change in
demo.jsis just to validate it's working correctly.