Bugs / IPFS not found error handling #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #108
Kubo developers unfortunately decided to report failure to find a CID as
HTTP 500status code, because returning404would imply non-existence, and IPFS is decentralized thus cannot guarantee the CID actually does not exist.I don't agree with this reasoning as it makes impossible to distinguish actual malfunction of the IPFS HTTP gateway from "I tried, but didn't find CID in reasonable time". But we'll have to live with it I guess.
Also localized IPNS-related shenanigans in
DatasetFactoryImpl, offloading a bit of responsibilities from too complexSyncServiceImpl.