Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes to extensions dictionary #19

Merged

Conversation

AVitg
Copy link
Contributor

@AVitg AVitg commented Nov 3, 2023

Hey @kamushadenes, i looked into the extensions dictionary, and found some minor issues, test run with pytest worked for me.

  • fixed: deviceCustomString1-6 length allowed to 4000 chars
  • fixed: deviceInboundInterface/ deviceOutboundInterface allowed 128 chars
  • removed: duplicate dhost
  • added: dtz - deviceTimeZone
  • implemented fix for issue flexString fields #9 /flexString/flexdate naming

fixed:  deviceCustomString1-6 length allowed to 4000 chars
fixed: deviceInboundInterface/ deviceOutboundInterface allowed 128 chars
removed: duplicate dhost
added: dtz - deviceTimeZone
implemented fix for issue kamushadenes#9 /flexString/flexdate naming
@kamushadenes kamushadenes merged commit f7635c5 into kamushadenes:master Nov 3, 2023
@kamushadenes
Copy link
Owner

Thanks!

@AVitg AVitg deleted the fix-to-extensions-dictionary branch November 3, 2023 09:28
@AVitg
Copy link
Contributor Author

AVitg commented Nov 3, 2023

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants