Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add singing vocoder and update f0 & excitation input feats #391

Merged
merged 38 commits into from
Mar 22, 2023

Conversation

DrWelles
Copy link
Contributor

@DrWelles DrWelles commented Feb 8, 2023

No description provided.

@DrWelles
Copy link
Contributor Author

  1. In parallel_wavegan/bin/preprocess.py, add two pitch-related features, f0 and excitation (sin-wave-based signals).
  2. In parallel_wavegan/models/uhifigan.,py, a new singing vocoder with excitation and mel as input, and a UNet-based generator.
  3. In parallel_wavegan/bin/normalize.py and parallel_wavegan/bin/decode.py, add MelF0ExcitationDataset to collect mel, f0 and excitation.
  4. In parallel_wavegan/bin/train.py, use a more flexible data loader for model inputs.

@ftshijt
Copy link
Contributor

ftshijt commented Feb 16, 2023

@kan-bayashi Hi Tomoki, as I mentioned to you days back, this is the implementation for a singing-specific vocoder. Could you please take a look to see if it fits into the repo? Many thanks!

@kan-bayashi
Copy link
Owner

Sorry for late reply, and thank you for your great PR.
I am a little bit busy in this month, I will check and revise when I finished my tasks...

@kan-bayashi
Copy link
Owner

Now I almost finished my jobs in this fiscal year!
Sorry for too late reviewing.
I will check and refactor this PR in this weekend.

@kan-bayashi
Copy link
Owner

kan-bayashi commented Mar 22, 2023

@DrWelles I refactored your PR (see #402)
If your branch seems master, so I'm wondering to push my changes to your repo.
Is it OK?

@DrWelles
Copy link
Contributor Author

@DrWelles I refactored your PR (see #402) If your branch seems master, so I'm wondering to push my changes to your repo. Is it OK?

Sure

@kan-bayashi
Copy link
Owner

Thanks. I listed some points of my changes.

  • I modified your codes to be compatible with all modes
  • I removed duplicated codes (evaluate_*.py) and locate it in bin
  • I added debug recipe of uhifigan for yesno
  • I removed debug loggings
  • I removed uhifigan_single.py since it seems not used. Is it OK?

@DrWelles
Copy link
Contributor Author

Thanks. I listed some points of my changes.

  • I modified your codes to be compatible with all modes
  • I removed duplicated codes (evaluate_*.py) and locate it in bin
  • I added debug recipe of uhifigan for yesno
  • I removed debug loggings
  • I removed uhifigan_single.py since it seems not used. Is it OK?

Great! And it's OK to remove uhifigan_single.py. :)

@kan-bayashi kan-bayashi added the enhancement New feature or request label Mar 22, 2023
@kan-bayashi kan-bayashi merged commit 1884d32 into kan-bayashi:master Mar 22, 2023
@kan-bayashi
Copy link
Owner

Thank you so much for your great feature & sorry for late merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants