Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division by zero if a 0-width RAW rect is sent #197

Closed
jalfd opened this issue Oct 10, 2012 · 1 comment
Closed

Division by zero if a 0-width RAW rect is sent #197

jalfd opened this issue Oct 10, 2012 · 1 comment
Milestone

Comments

@jalfd
Copy link

jalfd commented Oct 10, 2012

In display_raw() in rfb.js, the expression ws.rQlen()/(FBU.width * fb_Bpp) is problematic if FBU.width is zero.

Obviously, the server should not be sending empty rects in the first place, but we came across a problem where it happened, and currently it causes NoVNC to disconnect entirely.

@samhed samhed added fixed and removed patchwelcome labels Jun 15, 2018
@samhed samhed added this to the v1.0.0 milestone Jun 15, 2018
@samhed
Copy link
Member

samhed commented Jun 15, 2018

This code doesn't exist anymore.

@samhed samhed closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants