Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negotiation fail when empty sub-auth types received #564

Closed
wants to merge 1 commit into from

Conversation

avost
Copy link

@avost avost commented Dec 16, 2015

When a TightVNC server configured to allow no-auth connection, it may sends (the recent TightVNC server actually sends) an empty 'sub-auth' capabilities list at tight security type sub-auth negotiation phase. In this case noVNC viewer fails on negotiation with ''Unsupported tiny auth scheme:" message.
Fix this to assume 'no-auth' authentication subtype selected when received an empty auth capabilities list.

@DirectXMan12 DirectXMan12 self-assigned this Dec 16, 2015
@DirectXMan12 DirectXMan12 added this to the v0.7.0 milestone Sep 17, 2016
@DirectXMan12 DirectXMan12 added bug and removed feature labels Sep 17, 2016
@DirectXMan12
Copy link
Member

For future reference, the RFB proto says this about TIGHT auth:

If number-of-auth-types is non-zero, the client has to request an authentication type from the list with an authentication scheme request
...
If number-of-auth-types is zero, the protocol the proceeds directly at security type None.

(https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#723tight-security-type), which matches the change in this PR.

Copy link
Member

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase, which I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants