Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Panel Holoviz #37

Open
arifin-chemist89 opened this issue Feb 24, 2023 · 6 comments
Open

Add support for Panel Holoviz #37

arifin-chemist89 opened this issue Feb 24, 2023 · 6 comments

Comments

@arifin-chemist89
Copy link

Thank you for developing an awesome program!
Related to other requests, I would like to ask about the supports for Panel Holoviz (https://panel.holoviz.org/).
Please let me know if it is better to ask the Panel's developers about it.
Thanks in advances.

@Asm-Def
Copy link
Collaborator

Asm-Def commented Feb 24, 2023

Actually, they've already been usable together since PyGWalker allowed rendering data directly to HTML code with pyg.to_html from #25. you can try

html_pannel = pannel.pn.HTML(pyg.to_html(df))
html_pannel

for it.

But this is not always an elegant solution, because it actually embeds all the data in the web page, and does not effectively use the data-interaction capabilities provided by Panel. We're looking forward to your feedback and ideas about it.

BTW: Welcome to join our discord discord invitation link to keep track of the latest progress.

@philippjfr
Copy link

I've been trying to integrate this more deeply (e.g. to allow leveraging binary communication to send the data to the browser). However in Panel 1.0 (to be released in the near future) each component has to render into the shadow DOM. I've been trying to get that working but am experiencing some issues because graphic-walker does not much like being rendered into the shadow DOM. Any thoughts on what it would make that a supported configuration? Should I raise an issue in the graphic-walker repo?

@philippjfr
Copy link

Okay, ignore me, I just need to wrap graphic-walker directly:

Screen Shot 2023-02-24 at 18 09 51

@Asm-Def
Copy link
Collaborator

Asm-Def commented Feb 24, 2023

@philippjfr Congrats on your achievement! Looking forward to your new release and subsequent feedback.

@philippjfr
Copy link

While I have you, what's the rough expectation on what the rough magnitude in the size of data you expect graphic-walker to stay performant with?

@Asm-Def
Copy link
Collaborator

Asm-Def commented Feb 25, 2023

While I have you, what's the rough expectation on what the rough magnitude in the size of data you expect graphic-walker to stay performant with?

For the current version of graphic-walker, we tested about 70 MB CSV (with 800,000 rows X 12 columns).

and there's been some works on the performance these days, maybe released in a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants