Skip to content
This repository has been archived by the owner on Dec 24, 2020. It is now read-only.

Fix calendar drag #18

Closed
wants to merge 4 commits into from
Closed

Conversation

smacz42
Copy link

@smacz42 smacz42 commented Mar 1, 2019

@smacz42
Copy link
Author

smacz42 commented Mar 25, 2019

Bump

@smacz42
Copy link
Author

smacz42 commented Mar 28, 2019

Bump @fguillot

@Grekkor
Copy link

Grekkor commented Apr 1, 2019

@smacz42 I have implemented the changes you proposed and now I can effectively move all tasks but they are duplicated and the start and end date are not correct. It has to do with the fact that the task considers the creation date and not the start date. If no start date is set then the task exists twice, if it is set then even when dragging it around the task due date is updated but the the starting date is not considered.

@Grekkor
Copy link

Grekkor commented Apr 1, 2019

I was able to properly fix this issue. I will create a pull request for it soon.
The plugin should however, be rewritten as it very messy compared to other plugins.

@smacz42
Copy link
Author

smacz42 commented Apr 23, 2019

I was able to properly fix this issue. I will create a pull request for it soon.
The plugin should however, be rewritten as it very messy compared to other plugins.

I have not seen a PR on this yet. What type of changes did you have to make to fix the issue?

@smacz42
Copy link
Author

smacz42 commented May 8, 2019

@Grekkor bump^

FWIW, I wouldn't mind just writing the changes into my PR if you give me a snippet of what needs to be changed.

@mer30hamid
Copy link
Contributor

mer30hamid commented Oct 24, 2019

Fixes #11

I checked your changes and examined it, It also Fixes #22 !!
Thank you !

Edit: I checked and examined it more, It shows tasks with no "start date" and "due date", I think its a bug and problem with Persian language.

@mer30hamid
Copy link
Contributor

Fixes #11

I checked your changes and examined it, It also Fixes #22 !!
Thank you !

Edit: I checked and examined it more, It shows tasks with no "start date" and "due date", I think its a bug and problem with Persian language.

As I said here: https://github.com/kanboard/plugin-calendar/issues/22#issuecomment-533231310
Edited "locale-all.js" and it fixed, but is there any way to fix it without touching the fullcalendar files?

@smacz42
Copy link
Author

smacz42 commented Oct 25, 2019

Edit: I checked and examined it more, It shows tasks with no "start date" and "due date", I think its a bug and problem with Persian language.

Can you describe that a little more? And does this happen with english too?

@mer30hamid
Copy link
Contributor

mer30hamid commented Oct 25, 2019

Edit: I checked and examined it more, It shows tasks with no "start date" and "due date", I think its a bug and problem with Persian language.

Can you describe that a little more? And does this happen with english too?

Sorry for my bad English, No, this happens just for languages that have this weird number conversion (As I said here: https://github.com/kanboard/plugin-calendar/issues/22#issuecomment-533231310)

@smacz42
Copy link
Author

smacz42 commented Dec 8, 2020

I see in #22: It seems that this problem is fixed in "Kanboard 1.2.13", perhaps this was an issue about the Kanboard! So that seems to be fixed.

I have not seen any PR from @Grekkor with any fixes. This PR should fix the immediate problem, and the any residual issues can be addressed later?

@fguillot
Copy link
Member

This plugin is now archived. Unfortunately, I do not have the time to maintain or review pull-requests for this plugin. Fork this project if you would like to keep it alive.

@fguillot fguillot closed this Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants