Skip to content

Commit

Permalink
Merge pull request #368 from isaacchansky/kandan-359
Browse files Browse the repository at this point in the history
added setting for disabling connect, disconnect activity in admin panel
  • Loading branch information
fusion94 committed May 25, 2014
2 parents 7a6fee7 + f788871 commit 062115d
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 9 deletions.
11 changes: 6 additions & 5 deletions app/controllers/admin/admin_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ def index
def update

max_rooms = params[:setting][:max_rooms].to_i
public_site = params[:setting][:public_site] == "1"
public_site = params[:setting][:public_site] == "1"
disable_conn_disconn_activity = params[:setting][:disable_conn_disconn_activity] == "1"

Setting.set_values(:max_rooms => max_rooms, :public_site => public_site)
Setting.set_values(:max_rooms => max_rooms, :public_site => public_site, :disable_conn_disconn_activity => disable_conn_disconn_activity)

redirect_to :admin_root
end
Expand Down Expand Up @@ -47,8 +48,8 @@ def toggle_admin

user.save!

render :json => user, :status => 200
render :json => user, :status => 200
end

end
end
end
10 changes: 7 additions & 3 deletions app/models/channel.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class Channel < ActiveRecord::Base

validates :name, :presence => { :message => "Room name cannot be blank"}, :uniqueness => { :message => "Room name is already taken" }
validates :user, :presence => { :message => "Room must belong to a user"}

before_create :ensure_app_max_rooms

def ensure_app_max_rooms
Expand All @@ -26,14 +26,18 @@ def user_connect(user)
activity = Channel.primary.activities.new
activity.user_id = user.id
activity.action = "connect"
activity.save!
unless Setting.my_settings.disable_conn_disconn_activity
activity.save!
end
end

def user_disconnect(user)
activity = Channel.primary.activities.new
activity.user_id = user.id
activity.action = "disconnect"
activity.save!
unless Setting.my_settings.disable_conn_disconn_activity
activity.save!
end
end
end
end
11 changes: 10 additions & 1 deletion app/models/setting.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ def max_rooms
self.values[:max_rooms]
end

def disable_conn_disconn_activity
self.values[:disable_conn_disconn_activity]
end

def public_site?
self.values[:public_site]
end
Expand All @@ -36,8 +40,13 @@ def validate_public_site
!!self.values[:public_site] == self.values[:public_site] unless self.new_record?
end

# make sure disable connect/disconnect a boolean
def validate_conn_disconn
!!self.values[:disable_conn_disconn_activity] == self.values[:disable_conn_disconn_activity] unless self.new_record?
end

def self.default_values
{:max_rooms => Kandan::Config.options[:max_rooms], :public_site => Kandan::Config.options[:public_site]}
{:max_rooms => Kandan::Config.options[:max_rooms], :public_site => Kandan::Config.options[:public_site], :disable_conn_disconn_activity => Kandan::Config.options[:disable_conn_disconn_activity]}
end

# Helper methods to be used while we don't need to deal with multi-tenancy
Expand Down
6 changes: 6 additions & 0 deletions app/views/admin/admin/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
<%= f.label :max_rooms do %>
Max number of rooms <%= f.number_field :max_rooms, :class => "input-mini pull-right" %>
<% end %>
<%= f.label :disable_conn_disconn_activity do %>
<%= f.check_box :disable_conn_disconn_activity, :class => "switch" %> disable connect/disconnect activity
<span></span>
<% end %>
<%= f.label :public_site do %>
<%= f.check_box :public_site, :class => "switch" %> Public site
<span></span>
Expand Down
2 changes: 2 additions & 0 deletions config/kandan_settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

:max_rooms: 99

disable_conn_disconn_activity: true

:public_site: true

:avatar_url: https://secure.gravatar.com/avatar/%{hash}?s=%{size}&d=%{fallback}
Expand Down

0 comments on commit 062115d

Please sign in to comment.