Merge pull request #212 from mjtko/fix/repeated-id

Refactor integration test to not require standards violating repeated element ID
kandanapp · Mar 14, 2013 · 82cfd2c · 82cfd2c
2 parents 989d673 + 6f2b972
commit 82cfd2c
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 8 deletions.
diff --git a/app/assets/javascripts/backbone/broadcasters/faye.js.coffee.erb b/app/assets/javascripts/backbone/broadcasters/faye.js.coffee.erb
@@ -1,7 +1,7 @@
 class Kandan.Broadcasters.FayeBroadcaster
 
   constructor: ()->
-    @fayeClient = new Faye.Client("<%= ENV['FULL_HOST'] %>/remote/faye")
+    @fayeClient = new Faye.Client("<%= ENV['KANDAN_FAYE_URL'] %>/remote/faye")
 
     @fayeClient.disable('websocket')
     authExtension = {

diff --git a/app/assets/templates/chatbox.jst.eco b/app/assets/templates/chatbox.jst.eco
@@ -1,2 +1,2 @@
-<textarea class="chat-input" id="chat-input"></textarea>
+<textarea class="chat-input"></textarea>
 <button class="post">Post</button>
diff --git a/config/environments/test.rb b/config/environments/test.rb
@@ -36,6 +36,7 @@
   config.active_support.deprecation = :stderr
 
   # Variable set to be able to get faye client for test environments
-  ENV['FULL_HOST'] = "http://localhost:9292"
+  ENV['KANDAN_FAYE_PORT'] = "9292" unless ENV['KANDAN_FAYE_PORT']
+  ENV['KANDAN_FAYE_URL'] = "http://localhost:#{ENV['KANDAN_FAYE_PORT']}" unless ENV['KANDAN_FAYE_URL']
 
 end
diff --git a/lib/broadcasters/faye.rb b/lib/broadcasters/faye.rb
@@ -13,7 +13,7 @@ def broadcast(channel, message)
       end
 
       def assets
-        ["#{ENV['FULL_HOST']}/remote/faye.js"]
+        ["#{ENV['KANDAN_FAYE_URL']}/remote/faye.js"]
       end
     end
   end

diff --git a/spec/features/login_spec.rb b/spec/features/login_spec.rb
@@ -23,19 +23,21 @@
     page.should have_content(@user.first_name)
     page.should have_content(@user.last_name)
 
-    fill_in "chat-input", :with => "Hello there"
+    expect(page).to have_css('.chat-input')
+    chat_input = find(:css, ".chat-input")
+    chat_input.set "Hello there"
     click_button "Post"
 
     within("#channel-activities-1") do
       page.should have_content("Hello there")
     end
 
-    fill_in "chat-input", :with => "Hi again"
+    chat_input.set "Hi again"
     click_button "Post"
 
     within("#channel-activities-1") do
       page.should have_content("Hi again")
     end
 
   end
-end
+end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -34,7 +34,7 @@
   ActiveUsers.remove_by_client_id(client_id)
 end
 
-Thread.new {faye_server.listen(9292)}
+Thread.new {faye_server.listen(ENV['KANDAN_FAYE_PORT'].to_i)}
 
 Capybara.app = Rack::URLMap.new({
   "/"        => Kandan::Application