Fixed mention regex #141
Merged
Fixed mention regex #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran several tests through a regex tester. They passed. Since it's not on a branch testing is going to be a bit more fun. Running it still has problems in that the @ popup still appears. |
|
Yeah it looks like the at.js plugin will only let us do either "@" (which causes what you are seeing) or " @" which will fix this issue but will break when the mention is the first word on the line. I will dig deeper into the plugin and check if I can add regex as an option to pass into it |
|
I've added a new #157 to deal with the popup opening when typing email addresses |
ghost
assigned
donthorp
added a commit
that referenced
this pull request
Mar 1, 2013
Fixed mention regex. Unhighlights FULL email address, doesn't stop popup.
ar7em
pushed a commit
to ar7em/kandan
that referenced
this pull request
Jun 9, 2013
Fixed mention regex. Unhighlights FULL email address, doesn't stop popup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.