Add 'history' capability to the chatbox input #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -11,7 +11,7 @@ class Kandan.Views.Chatbox extends Backbone.View | |||
|
|
|||
|
|
|||
| postMessageOnEnter: (event)-> | |||
| if event.keyCode == 13 | |||
| if event.keyCode == 13 && !(event.metaKey || event.shiftKey || event.altKey || event.ctrlKey) | |||
There was a problem hiding this comment.
I think this would be easier to read if it would be:
if event.keyCode == 13 && !event.metaKey && !event.shiftKey && !event.altKey && !event.ctrlKey
Could you also add some comments on why the key booleans 😌
gabceb
added a commit
that referenced
this pull request
Mar 7, 2013
Add 'history' capability to the chatbox input
ar7em
pushed a commit
to ar7em/kandan
that referenced
this pull request
Jun 9, 2013
Add 'history' capability to the chatbox input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a plugin that gives the chatbox input area 'history' capabilities:
Also, this PR reinstates the capability of entering multiline text using alt+enter.