Updated mention sound - now works cross-browser #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… threetone-alert.wav to replace gong.mp3 for mention sounds; updated music_player to remove references to unused/obsolete MP3s.
ghost
assigned
gabceb
added a commit
that referenced
this pull request
Mar 9, 2013
Updated mention sound - now works cross-browser
ar7em
pushed a commit
to ar7em/kandan
that referenced
this pull request
Jun 9, 2013
…ound Updated mention sound - now works cross-browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the MP3 files and references as there is no browser support for MP3 files in Firefox or Opera.
I've replaced to 'gong' sound with a three-tone alert sound for mentions. We might want to consider implementing multiple formats and branching based on Modernizr.audio values, eg. from Chrome: