Add ownership to channels and associated enhancements

[mjtko]

This is a bit of a big one, so I want to get it open for discussion.

This PR fixes both #131 and #154 by introducing Cancan to manage authorization. Channels are now owned by a user. A user may only delete a channel they own, unless they are an admin. Nobody may delete channel id=1.

As always, feedback/questions welcomed! 😺

[coveralls]

Coverage increased (+1.92%) when pulling c21ace8 on mjtko:kandan-131 into ff6530a on kandanapp:master.

View Details

[gabceb]

I would appreciate some comments especially on that last commit 👮

[gabceb]

Overall this looks good. I have to pull it down and test it. 👍 for using CanCan

[fusion94]

This is pretty much how I envisioned it working. It's a good first start but over time will need improvements. Ie channels will eventually need to have the concept of private vs public etc.

Thoughts?

[fusion94]

Also to note is that I won't be able to test until tomorrow

[mjtko]

Latest commits:

1. I've tried to make the FFBT a bit less flaky by increasing the timeout when looking for .chat-input.
2. @gabceb: I've refactored kandan.js.coffee a little and added some comments so hopefully it's slightly more obvious what's going on now.

@fusion94: Yup, this is definitely just a starting point and will need improvements - was initially focussing on fixing #131 before considering branching out into more fine-grained control of channels (which will need UI improvements for modifying, creating etc.).

[coveralls]

Coverage increased (+1.92%) when pulling 4338246 on mjtko:kandan-131 into ff6530a on kandanapp:master.

View Details

[fusion94]

Ok so I installed this locally and ran into issues.
When I run bundle exec rake db:create db:migrate kandan:bootstrap I get the following errors:

rake aborted!
undefined method `attributes' for nil:NilClass

Here's a gist of the full output: https://gist.github.com/fusion94/5195247

Once I start up the server I see this almost immediately:

Started GET "/channels/undefined/attachments" for 127.0.0.1 at 2013-03-19 03:56:50 -0700
Processing by AttachmentsController#index as JSON
  Parameters: {"channel_id"=>"undefined"}
  User Load (0.1ms)  SELECT "users".* FROM "users" WHERE "users"."id" = 1 LIMIT 1
  Channel Load (0.1ms)  SELECT "channels".* FROM "channels" WHERE "channels"."id" = ? LIMIT 1  [["id", "undefined"]]
Completed 404 Not Found in 2ms

ActiveRecord::RecordNotFound - Couldn't find Channel with id=undefined:

Here's a gist of the full output: https://gist.github.com/fusion94/5195255

Now once I logon I get this:

So has something changed? Is your PR missing something?

[mjtko]

This is probably because I didn't update the kandan:bootstrap rake task. My working theory is that no channel is ever being created, probably due to it not being allocated a user. I'll prod it and see.

[fusion94]

@mjtko right on, just let us know what you find out.

[mjtko]

Ok, that should fix it I reckon.

[coveralls]

Coverage increased (+1.85%) when pulling 83de39a on mjtko:kandan-131 into ff6530a on kandanapp:master.

View Details

[mjtko]

Hmm, no idea wtf travis is on about this time. Is our/their ruby 2.0 test environment borked?

[fusion94]

I think their's might be as it works for me in ruby 2.0