Fixing Specs so that they now pass, which could have caused travis-ci to... #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,10 @@ | |||
| ActiveUsers.remove_by_client_id(client_id) | |||
| end | |||
|
|
|||
| Thread.new {faye_server.listen(ENV['KANDAN_FAYE_PORT'].to_i)} | |||
| Thread.new { | |||
| EM.run | |||
There was a problem hiding this comment.
If we don't have this in there, we get errors when we run the specs that say:
RuntimeError:
eventmachine not initialized: evma_install_oneshot_timer
This was prevalent before, as seen here:
If we don't have EM run in the thread, Faye will have trouble working
|
By adding in these changes, we can get all the specs to pass, which will help travis-ci stop having so many issues. We also need to refresh the heroku install, because the demo app on Heroku is broken. |
|
Merging...in regards to demo server see: #338 Will get that done tonight after work |
fusion94
added a commit
that referenced
this pull request
Apr 18, 2014
Fixing Specs so that they now pass, which could have caused travis-ci to...
|
@scouttyg also please send me an intro email to fusion94 AT gmail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... keep failing