Updated styles #352
Merged
Updated styles #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: app/assets/stylesheets/chat_area/_activity.sass
Conflicts: app/assets/stylesheets/chat_area/_activity.sass
…e up entire window.
|
Looks fine to me, I just tried out the design changes and it looks good on the eyes. I definitely like the new disconnect/connect stuff. Unless anyone has any issues with this (couple days), I'll pull this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up a bunch of styling to tighten up the UI in the chat/activity area. This includes things like less-intrusive connect/disconnect activities, single-line messages to fit more on the page, aligned username/message bodies for easier scrolling, etc.
I'm not sure if these updates align with the vision of the project or if we should just maintain these updates in our own fork, but figured since we did the work, we might as well at least submit them. Here are before/after screenshots:
Before
After
And then responsive styles as well:
Before (mobile)
After (mobile)