Support hubot api #438
Closed
Support hubot api #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
In previous PR , I just put API related resources out of constraints (authenticated :user). Because it is not working for channels:activities nested resource, put these out of authorized_or_have_token constraints. welcome suggestions! |
|
Due to a failure of Travis CI test, I've reverted last modifications. It will be tried again in a separate PR. |
|
Drop here and I'd like to submit cleaned PR agian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#393 is incomplete support for hubot master branch. It produce 404 error for /me? /channels? api access.
because API with auth_token is considered as unauthorized access in routes.rb.
Here is additional fix to #393 PR.
This PR is tested against hubot master.