Spec updates, gem updates, lots more. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thanks @jrgifford will be looking at this further. |
| gem 'guard' | ||
| gem 'guard-rspec' | ||
| gem 'database_cleaner' | ||
| gem 'jasmine', :git => 'https://github.com/pivotal/jasmine-gem.git', :branch => '1.2.rc1' |
There was a problem hiding this comment.
any reason you're using from git there?
There was a problem hiding this comment.
That was not my commit:
There was a problem hiding this comment.
ah, ok. sorry, i forgot i did that.
i'll move that out, pretty sure 1.2 is released by now.
jrgifford
added a commit
that referenced
this pull request
Jan 24, 2013
Spec updates, gem updates, lots more.
ar7em
referenced
this pull request
in ar7em/kandan
Jun 9, 2013
Spec updates, gem updates, lots more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will be using Kandan a lot more in the near future and I thought I'd add some of my changes that should be helpful.
Updated specs, found a few blocks that were calling methods more than once which was slowing things down a little. Also, updated deprecated FactorGirl calls. Tests run a lot cleaner now. Next to come is stubs for controller calls.
Changed a lot of the context blocks in specs and moved some of the tests to use expects instead of just 'should' syntaxing, those are personal preference.