Single-key turbo mode #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes any key a Turbo-Mode modifier. Before only if Alt, Ctrl, Shift, and Meta were held down, you could browse through the menu in "Turbo-Mode". Now this is possible with any key. This makes it possible to easily use Turbo-Mode even if a menu is bound to a single key without a modifier.
There's a small caveat though: In order to know that a key is pressed, we have to rely on key repeat: When you keep a key pressed, after a short delay (maybe half a second?) the OS will spam an app with key-down events. However, during this short period until the key-repeat events start to arrive, we cannot enter Turbo mode yet. So there will be a small delay after you opened the menu in which Turbo-Mode will not yet work.
If this delay is too long for your liking, you can hit the key quickly twice - this way Kando will get the key-down event and Turbo-Mode will work right out of the box!