Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warnings by reordering headers #28

Merged
merged 1 commit into from
Oct 21, 2015

Conversation

eddelbuettel
Copy link
Contributor

This covers only one of the two files emitting a fair amount of warnings. I'll try to get to the other one too.

@eddelbuettel
Copy link
Contributor Author

It is driving me a little batty that I cannot get of the warnings when compiling src/bigmemory.cpp. Hm.

kaneplusplus added a commit that referenced this pull request Oct 21, 2015
remove warnings by reordering headers
@kaneplusplus kaneplusplus merged commit 3197759 into kaneplusplus:master Oct 21, 2015
@kaneplusplus
Copy link
Owner

Many thanks!

@eddelbuettel
Copy link
Contributor Author

Oh, you were too fast. I figured it out and wanted to expand the PR but somehow it did not let me -- so just sent you a new one.

@kaneplusplus
Copy link
Owner

OK, sounds good.

@eddelbuettel
Copy link
Contributor Author

Is this ok / expected or an issue: https://travis-ci.org/kaneplusplus/bigmemory/builds/86677806 ?

@kaneplusplus
Copy link
Owner

I think it's a coveralls issue. I usually hit restart the build until it works or gives a more definitive error related to the packages.

@eddelbuettel
Copy link
Contributor Author

I may be blind but I do not see the 'retickle this' button...

@kaneplusplus
Copy link
Owner

It's on the right under settings. I've restarted.

@eddelbuettel
Copy link
Contributor Author

I looked, I only see 'requests' -- may be different for you as "owner".

@kaneplusplus
Copy link
Owner

That's probably right. Thanks again, I've merged the second pull request. It's building without problems on Linux and I built it on my Mac. This was extremely helpful.

@eddelbuettel
Copy link
Contributor Author

My pleasure -- I much prefer clean builds too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants