Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-continuous element support #38

Merged
merged 5 commits into from
Jun 9, 2016
Merged

Conversation

cdeterman
Copy link
Contributor

Previously users could only index single elements or contiguous regions for simple functions like read/write (e.g. bm[1:3,1:3]). These new changes allow users to index non_contiguous elements that mirror the normal R matrix/data.frame syntax for use cases such as bm[c(1,2,5)] or bm[c(2,4)] <- 42. Relevant unit tests have been added.

@cdeterman cdeterman closed this Jun 6, 2016
@cdeterman cdeterman reopened this Jun 6, 2016
@cdeterman
Copy link
Contributor Author

FYI, you may notice that coverage has decreased significantly but this is because coveralls is now also looking through all the C++ files as well as the R files.

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.6%) to 0.154% when pulling c4b98fb on cdeterman:master into 9af7ae6 on kaneplusplus:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.6%) to 0.154% when pulling c4b98fb on cdeterman:master into 9af7ae6 on kaneplusplus:master.

@cdeterman
Copy link
Contributor Author

Something actually seems off here, somehow coveralls isn't recognizing anything. I will keep looking into this. Everything still functions correctly though.

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.6%) to 0.154% when pulling d646e33 on cdeterman:master into 9af7ae6 on kaneplusplus:master.

@kaneplusplus
Copy link
Owner

Please note that you could index non-contiguous subsets. You can not create a sub.big.matrix on a non-contiguous subset.

@cdeterman
Copy link
Contributor Author

cdeterman commented Jun 7, 2016

@kaneplusplus these changes aren't for subsets. They are just for access to individual elements. It was previously not possible to index a big.matrix object with a single argument (e.g. bm[3]) for the third element where you previously needed bm[3,1].

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.6%) to 0.154% when pulling 0b39457 on cdeterman:master into 9af7ae6 on kaneplusplus:master.

@kaneplusplus kaneplusplus merged commit 144c1c1 into kaneplusplus:master Jun 9, 2016
@kaneplusplus
Copy link
Owner

My mistake, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants