-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-continuous element support #38
Conversation
FYI, you may notice that coverage has decreased significantly but this is because coveralls is now also looking through all the C++ files as well as the R files. |
Something actually seems off here, somehow coveralls isn't recognizing anything. I will keep looking into this. Everything still functions correctly though. |
Please note that you could index non-contiguous subsets. You can not create a |
@kaneplusplus these changes aren't for subsets. They are just for access to individual elements. It was previously not possible to index a |
…ts, fixed documentation typo
My mistake, thanks for the clarification. |
Previously users could only index single elements or contiguous regions for simple functions like read/write (e.g.
bm[1:3,1:3]
). These new changes allow users to index non_contiguous elements that mirror the normal R matrix/data.frame syntax for use cases such asbm[c(1,2,5)]
orbm[c(2,4)] <- 42
. Relevant unit tests have been added.