Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix low test coverage #50

Merged
merged 3 commits into from
Sep 16, 2016
Merged

Fix low test coverage #50

merged 3 commits into from
Sep 16, 2016

Conversation

cdeterman
Copy link
Contributor

@cdeterman cdeterman commented Sep 16, 2016

There was some memory issues with the -O0 flag used by covr. This was in turn caused by some uninitialized variables. Fixing those solved the problem and should address issue #46.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6477307 on cdeterman:master into * on kaneplusplus:master*.

@privefl
Copy link
Contributor

privefl commented Sep 16, 2016

Nice!

@kaneplusplus kaneplusplus merged commit 0ffe325 into kaneplusplus:master Sep 16, 2016
@kaneplusplus
Copy link
Owner

This is great. Thanks very much @privefl.

@privefl
Copy link
Contributor

privefl commented Sep 16, 2016

No, no it's @cdeterman that did all the work.
I was just complimenting him.

@kaneplusplus
Copy link
Owner

Oops! Thanks @cdeterman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants