New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve calibration gradient detection algorithm #130
Comments
Potentially kneed could be used to find the knee/elbow for each calibration plot, not sure how robust it is. I guess it also depends if you want to add another library just for this feature. Additionally,I found that my DPS5005 would display 15mA open circuit (after calibration). Connecting a multimeter I found that it was always reporting 15mA above the real power. |
I've never seen kneed before, it's likely a lot more robust then whatever I've implemented. If we don't want people to have to Good thinking on the open circuit test. I think we can likely achieve this by just making sure that the Line 865 in 08331f4
Currently this line can give a value that is non-zero even when |
The current gradient detection algorithm does not work correctly in a noisy environment as discussed #120
This should be improved to prevent incorrect calibration
The text was updated successfully, but these errors were encountered: