Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.1: Enchants multiplying #71

Closed
Kiwinetic opened this issue Aug 16, 2020 · 7 comments
Closed

1.16.1: Enchants multiplying #71

Kiwinetic opened this issue Aug 16, 2020 · 7 comments
Labels

Comments

@Kiwinetic
Copy link

I am following Project Orion and when I give myself an item with the enchant it applies it to the item multiple times. I am trying to get it to only apply it once like every enchant. I was told this is a foundation issue.

What I am getting (no errors): https://i.imgur.com/veBbQWw.png, the more times I give myself the sword, the more times the enchant will be on one of them: https://i.imgur.com/MQ9r7Gc.png

What I am supposed to get (picture is from the video): https://i.imgur.com/uSMJKq0.png

The enchant class: https://pastebin.com/hzWTHQfb
The command class that gives me the item: https://pastebin.com/EHcAP50b

@Magnum97
Copy link
Contributor

What does the BlackEnchant class look like?

@Kiwinetic
Copy link
Author

What does the BlackEnchant class look like?

I linked it above, but here it is again: https://pastebin.com/hzWTHQfb

@Magnum97
Copy link
Contributor

Sorry- I don't know why I had trouble clicking on that earlier.. anyway I have an idea but I am not that experienced with SimpleEnchat, so I want to test it before I start spewing theories.

@Magnum97
Copy link
Contributor

Magnum97 commented Aug 17, 2020

Well so much for my theory. What I did for testing is create blank plugin, copied your command and enchant class and run on fresh server. If I understand you correctly enchants would be increased / duplicated with each run of /ce command. I was not able to show that. I only got a single enchant after running it 20 times.

Edit: I forgot to mention that I am using the latest version of Foundation, 5.6.2
2020-08-17_02 01 26

@ItzRozzaDev
Copy link

Edit: I forgot to mention that I am using the latest version of Foundation, 5.6.2

You cannot be using Foundation 5.6.2 the latest version that works is 5.5.6 as issue #69 is about that. Also this duplication glitch with enchants has been reported to me personally when the discord was open and I was helping out.

@Magnum97
Copy link
Contributor

I'm not saying that your problem is not possible. I'm just reporting that on a server with zero other plugins, and Foundation 5.6.2 that I could not replicate the problem. Hopefully someone else is able to help you.
I have uploaded the code I used to test it to https://github.com/Magnum97/BlackEnchant.git All you need to do to compile is run ./gradlew shadowJar or gradle.bat if on Windows. I included the jar as well for your convenience. In fact just prior to commenting I decided to compile with 5.5.6. Both are in that repo for you.

You cannot be using Foundation 5.6.2

Please check #70 re: 5.6.2 and how to fix it. It did not occur to me until after posting that I should include my versions as you may not have the same. I also rolled back my Foundation to 5.5.6 but could not duplicate the glitch. You might try running it alone on a server to see if there is something else interfering with it.

@kangarko
Copy link
Owner

This was a known issue fixed in Foundation 5.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants