Add results for GraalVM JavaScript #1323
Conversation
|
(the link has an SSL error btw) |
|
LGTM - could you add npm run-script(s) so that the commands to generate the results (and install the needed deps) are discoverable in the repo? |
|
Thanks, fixed the link. What run scripts do you expect exactly? GraalVM is compatible with Node.js, so all the pieces are in the repo already - you can use the |
|
like, |
|
ah, ok, gotcha, will add. |
|
I've added a script so you can do |
| @@ -42,7 +42,8 @@ | |||
| "pretest": "npm run lint", | |||
| "build:compilers": "node build.js compilers", | |||
| "git:clean": "if type git > /dev/null 2>&1; then git stash save --keep-index; fi", | |||
| "test:no_change": "npm run --silent git:clean && if npm run --silent build | grep 'Write to file'; then echo 'Please run `npm run build` and commit the changes.' && exit 1; fi" | |||
| "test:no_change": "npm run --silent git:clean && if npm run --silent build | grep 'Write to file'; then echo 'Please run `npm run build` and commit the changes.' && exit 1; fi", | |||
| "graalvm": "node --jvm --shared-array-buffer --intl-402 node.js" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I think the results should state that this was run on the nodejs mode, not embedded mode. |
|
I have added such a comment. |
Hi,
GraalVM (https://www.graalvm.org) is coming with JavaScript (and Node.js) support. This PR adds results for this engine.
GraalVM JavaScript is based on the Graal Java JIT compiler (https://github.com/oracle/graal). The source code is available at https://github.com/graalvm/graaljs
Supporting Node.js, GraalVM can reuse the
node.jsfile to generate the results. The commandline to reproduce is/path/to/graalvm-ce-1.0.0-rc3/bin/node --jvm --shared-array-buffer --intl-402 node.js. The results are based on GraalVM CE 1.0.0 RC3 (https://github.com/oracle/graal/releases/tag/vm-1.0.0-rc3).-- Christian