Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Canvas to 1.3.9 #2767

Closed
mahnunchik opened this issue Feb 2, 2016 · 11 comments
Closed

Update Canvas to 1.3.9 #2767

mahnunchik opened this issue Feb 2, 2016 · 11 comments

Comments

@mahnunchik
Copy link

Hi @kangax

Could you please update canvas node module to 1.3.9 for compatibility with node v4 and v5.

@asturur
Copy link
Member

asturur commented Feb 2, 2016

we have a compatibility problem for node4 regarding jsdom.
As of now we cannot make fabricjs compatible both with node 0.12 and node4.

@mahnunchik
Copy link
Author

@asturur Maybe there is sense to drop support for node 0.12 and maintain only node v4 and v5?

@Joesmi
Copy link

Joesmi commented Feb 8, 2016

Hello,

I am a bit new to node so I am perhaps misunderstanding, so bear with me kindly.
When I check the version of node-canvas that fabric is using, I get version 1.1.6.
The current version of node-canvas is 1.3.10.
I don't need a newer version of node as @mahnunchik but is it possible to upgrade node-canvas that fabric is using?

I am scrambling to get flipX-ed itext to be positioned the same way in node-fabric as in browser fabric, so I thought perhaps upgrading node-canvas would help????

Thanks in advance for any pointers.

Joesmi

@asturur
Copy link
Member

asturur commented Feb 8, 2016

You can update by yourself to latest canvas, ot works good with node 0.12, while in needs changes if you update jsdom.

This will not help with text handling under node as far as i know.

@Joesmi
Copy link

Joesmi commented Feb 8, 2016

Thanks @asturur
Pity about the text handling problem.

@asturur
Copy link
Member

asturur commented Feb 8, 2016

That depends on how libpango and libcairo (don t remember which one) handles text whitespace.

@mahnunchik
Copy link
Author

https://github.com/mahnunchik/fabric.js works perfect with Node 5 on Linux and Mac

@asturur
Copy link
Member

asturur commented Feb 8, 2016

does it work without updating jsdom? because here on travis it fails compilation if i put node 4 on and i do not put jsdom 6.5.x

@Joesmi
Copy link

Joesmi commented Feb 8, 2016

Thanks for the info, @asturur

@hugomrdias
Copy link

pls update this .. i'm stuck in node 0.12 only because of this

@asturur
Copy link
Member

asturur commented Apr 7, 2016

we updated to canvas 1.3.x and jsdom 3.x, allowing for node compatbility from 0.10 to 5
When 1.6.0 hits npm you should be fine.

@asturur asturur closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants