Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting after 'cut'-ing text in i-text pastes previous data from system clipboard #2773

Closed
Koosmann opened this issue Feb 5, 2016 · 18 comments · Fixed by #2868
Closed

Pasting after 'cut'-ing text in i-text pastes previous data from system clipboard #2773

Koosmann opened this issue Feb 5, 2016 · 18 comments · Fixed by #2868
Assignees

Comments

@Koosmann
Copy link

Koosmann commented Feb 5, 2016

On the kitchen sink demo, cmd+x and a subsequent cmd+v always pastes text cut/copied previously to the system clipboard.

This happens on osx 10.11.3 on chrome, safari, and ff.

@asturur
Copy link
Member

asturur commented Feb 8, 2016

i cannot replicate that i,m on windows.
Do you see some strange message in console?
Tomorrow i can try on a mac also.

@onassar
Copy link

onassar commented Feb 8, 2016

I can confirm.
Cmd+x does does cut the text from the text field, but does not copy it to the machine's clipboard.

@asturur
Copy link
Member

asturur commented Feb 8, 2016

on windows it copies fine, but does not carry style if i use "cut" command.
Pasting is fine.

Please can you check console for strange messages?

@onassar
Copy link

onassar commented Feb 8, 2016

Nothing in the console for me

@ozooner
Copy link
Contributor

ozooner commented Feb 19, 2016

Tested on Windows(8), Linux & Mac. Can confirm that cut does not put the text to clipboard on any of the platforms. Tested at http://fabricjs.com/test/misc/itext.html

@asturur
Copy link
Member

asturur commented Apr 6, 2016

guys can you check if this demo page i made with latest changes fixes this issue?
To me it looks yes, but i would like your opinion too.

http://www.deltalink.it/andreab/fabric/iphone.html

@ozooner
Copy link
Contributor

ozooner commented Apr 6, 2016

Works perfect on Linux!

@onassar
Copy link

onassar commented Jan 17, 2017

@asturur I'm pretty far behind from HEAD; is there anyway you can point me to the exact parts of 56c477f that are relevant to fixing the cut + paste bug?

@asturur
Copy link
Member

asturur commented Jan 17, 2017

i ll try!

@onassar
Copy link

onassar commented Jan 17, 2017

Thanks @asturur. Just comment here if you're able to and I'll test :)

@asturur
Copy link
Member

asturur commented Jan 18, 2017

ok i checked the commit, you have to insert it all.
The point is to handle CUT we now use the cut event and not the CTR+X keypress.
At least the commit you underlined is all necessary.

@asturur
Copy link
Member

asturur commented Jan 18, 2017

You should make an effort to switch to latest anyway, figure out what blocks you and see if is a stopper or not. I do not think we broke any api from 1.5 to now.

@onassar
Copy link

onassar commented Jan 18, 2017

Okay thanks I merged that entire commit and it's working as expected. Thanks @asturur

@onassar
Copy link

onassar commented Feb 1, 2017

@asturur I just realized this introduced a bug
Specifically, Command+a for selecting text is no longer working. Can you confirm this is happening on your side? When I remove the code, it works again.

@asturur
Copy link
Member

asturur commented Feb 1, 2017

please confirm that you can repro in kitchensink

@onassar
Copy link

onassar commented Feb 1, 2017 via email

@asturur
Copy link
Member

asturur commented Feb 1, 2017

its on latest while you are on older and patch right?

@onassar
Copy link

onassar commented Feb 1, 2017

You are correct. I found the fix and applied it. Thanks @asturur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants