Update use of getBoundingRect in Guides Example #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligning Guidelines Example broken. Update to use getBoundingRect() function
|
thanks! do guidelines work correctly? i do not check them since long |
|
Yes they work well in 2.0. Was just throwing a cant find getBoundingRectHeight() function error. So I updated the functions. |
asturur
reviewed
Jan 18, 2018
lib/aligning_guidelines.js
Outdated
| objectHeight = canvasObjects[i].getBoundingRectHeight() / viewportTransform[3], | ||
| objectWidth = canvasObjects[i].getBoundingRectWidth() / viewportTransform[0]; | ||
| objectHeight = canvasObjects[i].getBoundingRect().height / viewportTransform[3], | ||
| objectWidth = canvasObjects[i].getBoundingRect().width / viewportTransform[0]; |
There was a problem hiding this comment.
please use the same logic here, call boundingRect once, and then read width/height.
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* Update use of getBoundingRect in Guides Example Aligning Guidelines Example broken. Update to use getBoundingRect() function * Ensure getBoundingRect is called only once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning Guidelines Example broken. Update to use getBoundingRect() function