Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Error messages #100

Closed
Firstyear opened this issue Sep 23, 2019 · 1 comment · Fixed by #243
Closed

Refactor Error messages #100

Firstyear opened this issue Sep 23, 2019 · 1 comment · Fixed by #243
Milestone
1.1.0 alpha1

Comments

@Firstyear
Copy link
Member

The current error messages are getting a bit complicated, and aren't always clear.

I think these should be refactored to a two-level struct, with str messages in each error for helping communicate the cause of the issue. Doing this sooner than later would probably be a good idea
@Firstyear Firstyear added this to the release 1.0 milestone Oct 5, 2019
@Firstyear Firstyear mentioned this issue Oct 6, 2019
Closed
@Firstyear Firstyear modified the milestones: release 1.0, rc 1 Oct 6, 2019
@Firstyear Firstyear mentioned this issue Oct 7, 2019
Merged
Firstyear added a commit that referenced this issue Oct 10, 2019
@Firstyear
Refactor client lib to expose msgs, and improve the messages in plugi…
6b0b2ad 
…ns (#114)

Implements #100. This refactors our error types to be deserialiseable, and exposes these through the clienterror type with the status codes. There is probably still a lot of improvements here to be made, but they'll be shaken out as the client libs develop I think and we start to see what errors should be exposed.
@Firstyear
Copy link
Member Author

https://crates.io/crates/thiserror

Probably worth looking into

@Firstyear Firstyear mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0 alpha1
Development

Successfully merging a pull request may close this issue.

Improve errors, tagging, logging and more across the codebase. kanidm/kanidm
1 participant
@Firstyear