Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows-related build fixes #1344

Merged
merged 4 commits into from Jan 24, 2023
Merged

Windows-related build fixes #1344

merged 4 commits into from Jan 24, 2023

Conversation

yaleman
Copy link
Member

@yaleman yaleman commented Jan 24, 2023

It builds, but kanidmd stack-overflows on windows while running initialise_helper, something something DB-related-things, by the looks of it?

It wasn't compiling at all before the PR changes, so I didn't make it worse 😃

Relates to #1229

  • cargo fmt has been run
  • cargo clippy has been run
  • cargo test has been run and passes
PS C:\Users\yaleman\Projects\kanidm\kanidmd\daemon> cargo run --bin kanidmd server --config C:\Users\yaleman\AppData\Local\Temp\kanidm\server.toml
    Finished dev [unoptimized + debuginfo] target(s) in 0.52s
     Running `C:\Users\yaleman\Projects\kanidm\target\debug\kanidmd.exe server --config C:\Users\yaleman\AppData\Local\Temp\kanidm\server.toml`
Running on windows, current username is: "yaleman"
Running in server mode ...
WARNING: permissions checks on windows aren't implemented, cannot check TLS Key at "C:/Users/yaleman/AppData/Local/Temp/kanidm/chain.pem" 
WARNING: permissions checks on windows aren't implemented, cannot check TLS Key at "C:/Users/yaleman/AppData/Local/Temp/kanidm/key.pem"   
00000000-0000-0000-0000-000000000000 INFO     i [info]: Starting kanidm with configuration:  address: 127.0.0.1:8443, domain: localhost, 
ldap address: 127.0.0.1:3636, thread count: 16, dbpath: C:/Users/yaleman/AppData/Local/Temp/kanidm/kanidm.db, arcsize: AUTO, max request size: 262144b, secure cookies: true, trust X-Forwarded-For: false, with TLS: true, online_backup: enabled, role: write replica, integration mode: false, console output format: Text
Creating QS
Created QS
Helper starting

thread 'main' has overflowed its stack
error: process didn't exit successfully: `C:\Users\yaleman\Projects\kanidm\target\debug\kanidmd.exe server --config C:\Users\yaleman\AppData\Local\Temp\kanidm\server.toml` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)

kanidmd/daemon/src/main.rs Outdated Show resolved Hide resolved
@Firstyear
Copy link
Member

Good start! I can help investigate the issue with the segfault later :)

@yaleman
Copy link
Member Author

yaleman commented Jan 24, 2023

WOooooooOooOooo all the tests pass! 🥳

@yaleman yaleman merged commit 980cb31 into master Jan 24, 2023
@yaleman yaleman deleted the windows-fixes branch January 24, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants