-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions: #206
Add github actions: #206
Conversation
This PR is tested against my fork master. This allows to lint and test every commit except that with only affects documentation files. Build all commits in master and create You will need to setup your This is a basic CI but improves current one and could be improve. |
fe60e53
to
681849e
Compare
I tested here with other image names: kanidmd and kanidm_rlm_python. |
This could close #97 |
Hey there, this looks really cool. I didn't have time to review it today, but I promise I'll look tomorrow. Thanks so much! |
- Add linter with `cargo fmt` - Add tests - Add kanidmd docker build - Add kanidm_rlm_python docker build - Fix kanidm_unix_int format to pass tests
681849e
to
d86795b
Compare
Hey there, I already have docker hub configured to automatically pull and build, so I think I'll stick to that for the moment. Is it okay to just have the fmt/build/test work action in this change? Thanks! |
Hey! Ok if you want I could remove that jobs. I know that it's not the most elegant ones, it's almost copy paste but I think that improve docker hub ones.
If you want to explain more about that I could find another approach that convince you more. This is a first step to have a proper CI to automatize realises, I used GitHub actions because I wanted to try them but if you have preference for other software/technology I could implement it. |
Maybe I should do it this way. Docker hub is really slow to build and I didn't know it was failing to build :| so that's not good! But yeah, I like the idea of automating releases based on tags, so you know, I think I changed my mind and I'll accept this :) I need to do a few other things for work at the moment, but I'll merge this afternoon and setup the keys and tokens :) Thanks very much! PS: I setup https://gitter.im/kanidm/community to chat if you want to talk about things a bit easier. My timezone is UTC +10:00 |
cargo fmt