Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions: #206

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Conversation

pando85
Copy link
Contributor

@pando85 pando85 commented Apr 25, 2020

  • Add linter with cargo fmt
  • Add tests
  • Add server docker build
  • Add radius docker build
  • Fix kanidm_unix_int format to pass tests

@pando85
Copy link
Contributor Author

pando85 commented Apr 25, 2020

This PR is tested against my fork master.

This allows to lint and test every commit except that with only affects documentation files. Build all commits in master and create kanidmd and kanidm_rlm_python images latest for every commit and tagged against v* tags.

You will need to setup your DOCKERHUB_TOKEN and DOCKERHUB_USERNAME as secrets in Github settings.

This is a basic CI but improves current one and could be improve.

@pando85
Copy link
Contributor Author

pando85 commented Apr 25, 2020

I tested here with other image names: kanidmd and kanidm_rlm_python.

@pando85
Copy link
Contributor Author

pando85 commented Apr 25, 2020

This could close #97

@Firstyear
Copy link
Member

Hey there, this looks really cool. I didn't have time to review it today, but I promise I'll look tomorrow. Thanks so much!

- Add linter with `cargo fmt`
- Add tests
- Add kanidmd docker build
- Add kanidm_rlm_python docker build
- Fix kanidm_unix_int format to pass tests
@Firstyear
Copy link
Member

Hey there, I already have docker hub configured to automatically pull and build, so I think I'll stick to that for the moment. Is it okay to just have the fmt/build/test work action in this change? Thanks!

@pando85
Copy link
Contributor Author

pando85 commented Apr 27, 2020

Hey! Ok if you want I could remove that jobs. I know that it's not the most elegant ones, it's almost copy paste but I think that improve docker hub ones.

  • Docker hub radius is actually failing and this fix it.
  • this approach gives repository control over docker build configurations, that could be a little advantage.
  • I don't know if that jobs build on tags to release but this could be useful.
  • although this builds launch tests over docker images in all PRs that could be an advantage.

If you want to explain more about that I could find another approach that convince you more.

This is a first step to have a proper CI to automatize realises, I used GitHub actions because I wanted to try them but if you have preference for other software/technology I could implement it.

@Firstyear
Copy link
Member

Maybe I should do it this way. Docker hub is really slow to build and I didn't know it was failing to build :| so that's not good!

But yeah, I like the idea of automating releases based on tags, so you know, I think I changed my mind and I'll accept this :) I need to do a few other things for work at the moment, but I'll merge this afternoon and setup the keys and tokens :)

Thanks very much!

PS: I setup https://gitter.im/kanidm/community to chat if you want to talk about things a bit easier. My timezone is UTC +10:00

@Firstyear Firstyear merged commit 911b598 into kanidm:master Apr 27, 2020
@Firstyear Firstyear mentioned this pull request Apr 27, 2020
@pando85 pando85 deleted the feature/ci/github-actions branch April 28, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants