Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CredProps::rk should be public #421

Closed
smessmer opened this issue Feb 29, 2024 · 1 comment · Fixed by #434
Closed

CredProps::rk should be public #421

smessmer opened this issue Feb 29, 2024 · 1 comment · Fixed by #434

Comments

@smessmer
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Because of issues with the webauthn-rs serialization discussed in other Github issues, we're using our own custom serialization logic for passkeys. This means we serialize our own custom types and need access to the internals of the passkey struct so we convert from/to our own custom types. We do have access to most, but CredProps::rk is a field that we don't have access to. It is accessible from a passkey via the Credential::extensions property.

Describe the solution you'd like
Make CredProps::rk public

Describe alternatives you've considered
Ideally, we wouldn't have to do our own custom serialization logic, i.e. webauthn-rs would itself have a space-efficient and backwards compatible serialization layout. But until that's the case, this way works for us.

@Firstyear
Copy link
Member

I was thinking we need to address the serialisation side soon. @micolous We should catch up and resolve this once and for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants