Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Installation of the Operator on stateless Nodepools #2707

Closed
GeekYiwen opened this issue Feb 29, 2024 · 4 comments · Fixed by #2791
Closed

Enforce Installation of the Operator on stateless Nodepools #2707

GeekYiwen opened this issue Feb 29, 2024 · 4 comments · Fixed by #2791
Assignees
Projects

Comments

@GeekYiwen
Copy link

Is your feature request related to a problem? Please describe.
As Kanister is a stateless operator I would like to enforce that Kanister will be running on a stateless nodepool. Many other K8s operators allow the option to specify nodeSelector and tolerations in the values file to enforce this.

Describe the solution you'd like
Add the possibility to enforce the installation of the Kanister operator on a stateless nodepool. This should be done by passing values in the helm chart.

Example Values

nodeSelector:
  node_pool: "stateless"

tolerations:
  - key: "dedicated"
    operator: "Equal"
    value: "stateless"
    effect: "NoSchedule"
Copy link

Thanks for opening this issue 👍. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

@infraq infraq added this to To Be Triaged in Kanister Feb 29, 2024
@viveksinghggits
Copy link
Contributor

Hi @GeekYiwen ,
Thank you for reporting this. We discussed about this in the last community call and we think that it would be a great addition to the project. We will work on this soon.
If you have some bandwidth and want to work on this, let us know and we would be more than happy to help.

@GeekYiwen
Copy link
Author

Hi @viveksinghggits,
Thanks for tackeling this issue :D Sadly I am not that experienced in writing Golang and therefore don't think, that I can contribute any meaningful code for this issue. If there is any insights into the issue that you need I am happy to answer any questions if I know more about this. Thanks in advance for implementing 👍

@viveksinghggits
Copy link
Contributor

Sounds good @GeekYiwen . No problem, we will take this up. And for now we will make sure that users are able to configure the nodeSelector and tolerations fields of kanister-operator pod as part of this issue.

@hairyhum hairyhum removed the triage label Mar 14, 2024
@mergify mergify bot closed this as completed in #2791 Apr 30, 2024
Kanister automation moved this from To Be Triaged to Done Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants