Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes composer install, adds fencing for first time run #178

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Removes composer install, adds fencing for first time run #178

merged 1 commit into from
Mar 28, 2024

Conversation

thejimbirch
Copy link
Contributor

fin rebuild exists that includes composer install. Build needs a refresh command that doesn't have it.

The more important aspect is to gate the db request only if the config/core.extention.yml exists.

@thejimbirch thejimbirch requested a review from a team as a code owner March 27, 2024 12:58
@paulsheldrake
Copy link
Contributor

paulsheldrake commented Mar 27, 2024 •
edited
Loading

I disagree that refresh should not have composer install. I don't understand how that would break any developer workflow making sure your install composer packages work with the DB you just pulled. i think the rebuild command is just command bloat, and just unnecessary.

@paulsheldrake
Copy link
Contributor

That being said if you need this for your rock, I approve

@thejimbirch thejimbirch merged commit dc209ea into main Mar 28, 2024
@thejimbirch thejimbirch deleted the refresh-fix branch March 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulsheldrake paulsheldrake paulsheldrake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thejimbirch @paulsheldrake