Feature/embroider #1894
Draft
Feature/embroider #1894
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lowers the assets/frontend-kaleidos.js size from 20.8MB to 19.7MB
This lowers the bundle size to 16.8MB, a reduction of 4MB from the original.
This doesn't seem to benefit us right now, presumably because none of our routes can be lazily loaded? But it doesn't throw any new warnings/errors and it might be useful in the future.
…nd-kaleidos into feature/embroider
|
Updated it. Unsure if the rdfa editor personal commit was needed for some dependency fix or custom styling |
|
Woodpecker is not picking up this PR. |
The editor version we were using at the time didn't support Embroider builds, but any newer version should. The bump in this PR is probably unnecessary.
Not sure why, will have a look. |
|
The rdfa editor will be the prosemirror fix + the list styling. Might have to put this on hold until we can bump the rdfa editor first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Embroider build in Kaleidos, which using its static analysis lowers our bundle/
assets/frontend-kaleidos.jssize by 4MB (from 20.8MB to 16.8MB)Doesn't need to be merged, was more of a try to see how hard it'd be to convert Kaleidos to using Embroider (seemingly not very hard at all).