Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kas 4565 publicatie view binnen dossier #2101

Merged

Conversation

StuyckRuben
Copy link
Contributor

@StuyckRuben StuyckRuben commented May 6, 2024

@StuyckRuben StuyckRuben marked this pull request as ready for review May 8, 2024 07:48
…nd-kaleidos into feature/KAS-4565-publicatie-view-binnen-dossier
Copy link
Contributor

@tdn tdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things (see comments).

Most important one is the statuses panel, which doesn't work right now.

{{t "no-status"}}
</AuPill>
{{/if}}
{{else}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pill should be red (danger) in case of cancellation.

@StuyckRuben StuyckRuben requested a review from tdn June 19, 2024 13:32
Copy link
Contributor

@ValenberghsSven ValenberghsSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair reviewed.
Tested locally. minister and government profile can see all needed data.
minister after release decisions
government after release documents

@ValenberghsSven ValenberghsSven merged commit e0cbebf into development Jun 28, 2024
1 of 2 checks passed
@ValenberghsSven ValenberghsSven deleted the feature/KAS-4565-publicatie-view-binnen-dossier branch June 28, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants