feature/KAS-4629: updateBetreftContent & updateBeslissingenContent now generate text for bekrachtiging #2103
Conversation
…w generate text for bekrachtiging
…nd-kaleidos into feature/KAS-4629-bekrachtingsformule-standaard-in-beslissingsfiche
There was a problem hiding this comment.
generateBetreft is used also in minutes which this does not cover.
Is there a way we could only call generateBetreftonce in digital version?
Perhaps we could pass in subcase instead of just subcaseName and implement ratification logic in 1 spot rather then 2.
The ratification document could be collected in the generateBetreft and added to the list of documents if present.
| subcase?.subcaseName | ||
| ); | ||
| let newBetreftContent; | ||
| if (subcase?.isBekrachtiging) { |
There was a problem hiding this comment.
subcase?.isBekrachtiging (sync getter) needs await subcase?.type to resolve.
| if (subcase?.isBekrachtiging) { | ||
| newBeslissingHtmlContent = "De Vlaamse Regering bekrachtigt bovengenoemd decreet en beslist over te gaan tot de afkondiging ervan."; | ||
| } else if (this.args.agendaitem.isApproval) { |
There was a problem hiding this comment.
look into generateApprovalText, we might want something similar for both decisions and minutes?
Also, scopecreep: Could we use generateApprovalText here as well. duplicate code atm
| newBetreftContent = await generateBetreft( | ||
| subcase.shortTitle, | ||
| null, |
There was a problem hiding this comment.
We would probably still want to agendaitem.shorttitle here.
subcase title and agendaitem should be the same regardless
https://kanselarij.atlassian.net/browse/KAS-4629