Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAS-4652: now shows different message in AgendaGroupHeader if the subcase.type is bekrachtiging #2109

Merged
merged 10 commits into from
Jun 28, 2024
Merged

KAS-4652: now shows different message in AgendaGroupHeader if the subcase.type is bekrachtiging #2109

merged 10 commits into from
Jun 28, 2024

Conversation

StuyckRuben
Copy link
Contributor

@StuyckRuben StuyckRuben commented May 21, 2024 •
edited
Loading

@StuyckRuben StuyckRuben marked this pull request as draft May 21, 2024 13:56
@StuyckRuben StuyckRuben marked this pull request as ready for review May 23, 2024 09:31
sergiofenoll
sergiofenoll approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@sergiofenoll sergiofenoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected

@sergiofenoll sergiofenoll requested a review from tdn May 27, 2024 14:10
@ValenberghsSven
Merge branch 'development' of github.com:kanselarij-vlaanderen/fronte…
f446e2a 
…nd-kaleidos into feature/KAS-4652-edit-gele-rubriek-voor-bekrachtiging-en-afkondiging
ValenberghsSven
ValenberghsSven requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@ValenberghsSven ValenberghsSven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fully ok it seems. some comments
I have 2 ratifications locally.

There is some logic to include if a ratification subcase does have mandatees but that messes up the print view.
image
image

Should we show Jambon here or ratification?

app/controllers/agenda/agendaitems.js Outdated Show resolved Hide resolved
app/components/agenda/printable-agenda/list-section/item-group.js Outdated Show resolved Hide resolved
app/services/agenda-service.js Outdated Show resolved Hide resolved
tdn
tdn requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tdn tdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments left to be resolved.
Does work nicely already

app/components/agenda/printable-agenda/list-section/item-group.hbs Outdated Show resolved Hide resolved
app/services/agenda-service.js Outdated Show resolved Hide resolved
@StuyckRuben StuyckRuben requested a review from tdn June 19, 2024 12:10
@tdn tdn merged commit d0888df into development Jun 28, 2024
1 check was pending
@tdn tdn deleted the feature/KAS-4652-edit-gele-rubriek-voor-bekrachtiging-en-afkondiging branch June 28, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValenberghsSven ValenberghsSven ValenberghsSven requested changes

@tdn tdn tdn approved these changes

@sergiofenoll sergiofenoll sergiofenoll approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StuyckRuben @tdn @ValenberghsSven @sergiofenoll