Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden jQuery dependencies in db. #12

Open
mgmarino opened this issue Oct 6, 2014 · 0 comments
Open

Hidden jQuery dependencies in db. #12

mgmarino opened this issue Oct 6, 2014 · 0 comments

Comments

@mgmarino
Copy link
Member

mgmarino commented Oct 6, 2014

There are references to jQuery functions, including

$.ajax in request

and

within httpData. In the latter, $.parseJSON may be replaced with JSON.parse, $.error should be replaced by emitting an event, and $.globalEval could require some discussion.

It is true that it is noted that jQuery is required in the README, but if this is true, it should be included as a db dependency in kanso.json. I personally think it would make sense not to do this since it is a rather heavy one and it straightforward to replace the jQuery calls with javascript.

mgmarino added a commit to mgmarino/db that referenced this issue Oct 6, 2014
The jquery dependency is now explicitly included through require.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant