Move from nut2 to PyNUTClient #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 40c3f5d)
|
Thanks for the PR! Going to test this as is but could you change importing the module as
|
|
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Move from old nut2 Python lib to more recent, still supported and first party PyNUTClient Python lib.
How was it tested? How can it be tested by the reviewer?
I don't get any errors in Octoprint's log on my setup (Raspberry Pi OS Bookworm + OctoPrint 1.10.1 + CyberPower UPS over USB) although I do only have the one UPS handy to test with; that said, this PR should cover what the old library did 1:1.
What are the relevant tickets if any?
#16