Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #87 | Add type to button to prevent it triggering submit #116

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

Roshanjossey
Copy link
Collaborator

No description provided.

@kantord
Copy link
Owner

kantord commented Feb 19, 2020

thanks for the PR! Something seems to be not working with the CI? 🤔 Can you please try rebasing it to master and squashing your MR? I don't know why GitLab CI is not triggered at all

@Roshanjossey
Copy link
Collaborator Author

I tried this. It results in the same error. Let me try opening another pull request.

@Roshanjossey
Copy link
Collaborator Author

I tried another pull request and it also had the same error

@kantord
Copy link
Owner

kantord commented Feb 19, 2020

I realized what the issue is. Secrets cannot be shared with forks, since then it would be trivial to steal them. (You could just print them out to the console).

Therefore, to make the review app deployment work, you have to set the token for yourself. That's not ideal, but I have no better idea right now 🤔

Let's try this:

@kantord kantord changed the base branch from master to fix-87 February 20, 2020 09:43
@kantord kantord merged commit 4d0e533 into kantord:fix-87 Feb 20, 2020
kantord added a commit that referenced this pull request Feb 20, 2020
fixes #87

Co-authored-by: Roshan Jossy <roshanjossey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants